Update project Code of Conduct to match WordPress Project#2733
Conversation
GaryJones
left a comment
GaryJones
left a comment
There was a problem hiding this comment.
I checked the diff between the COC we had in the project, and the WP project one that this PR references. I think it makes sense to centralise and align on contributor expectations between WordPressCS and other repos under the WordPress banner.
There was a problem hiding this comment.
I'm okay with this.
The fact that WPCS had its own code of conduct was a historic artifact of the WordPress project not having one and WPCS identifying the need for one.
Now WP has a CoC, I'm happy to defer to the WP one.
FYI: We normally merge with two maintainer approvals - I'm going to leave this PR open for a few more days to allow the remaining two maintainers to pitch in though, in case they would have different views.
rodrigoprimo
left a comment
rodrigoprimo
left a comment
There was a problem hiding this comment.
I also agree with this change.
The only concern I have is that https://github.com/WordPress/WordPress-Coding-Standards/blob/develop/.github/CONTRIBUTING.md?plain=1#L32 points to the deleted WPCS CoC, and will have a broken link if this PR is merged as is. I would suggest updating the link to point to the WordPress Project CoC as a defensive change, so this PR is independent of #2735, but I'm open to other approaches as well.
|
@dd32 Seeing |
The local CODE_OF_CONDUCT.md is removed in this PR, so repoint the CONTRIBUTING.md reference to the WordPress Project Code of Conduct to avoid a broken relative link. Defensive change per review feedback, independent of WordPress#2735.
rodrigoprimo
left a comment
rodrigoprimo
left a comment
There was a problem hiding this comment.
Thanks for updating the link, @dd32.
5 participants
Description
This PR updates the repository to use the WordPress project's Code of Conduct rather than maintaining a project-specific one:
CODE_OF_CONDUCT.md, which predates the WordPress Coding Standards being part of the WordPress project.Suggested changelog entry
None required.
Related issues/external references
Related: #2722 (comment)
Partially supersedes #2724